infra-2026-10-045: WatchedRotatingFileHandler resistant au remplacement d inode

This commit is contained in:
bolbol committed 2026-10-12 09:24:05 +02:00
1 parent 67f33fc81e
commit a152e5a33f
2 files changed
+109 -2

No files matched your search

+51 -1
View File
@@ -56,7 +56,7 @@ class TestNotebookMcp(unittest.IsolatedAsyncioTestCase):
# Reconfigure logger
server.access_logger.handlers.clear()
rfh = server.logging.handlers.RotatingFileHandler(
rfh = server.WatchedRotatingFileHandler(
self.access_log_path, maxBytes=5 * 1024 * 1024, backupCount=3, encoding="utf-8"
)
rfh.setFormatter(server.logging.Formatter("%(message)s"))
@@ -65,6 +65,8 @@ class TestNotebookMcp(unittest.IsolatedAsyncioTestCase):
server.init_db()
def tearDown(self):
for h in list(server.access_logger.handlers):
h.close()
server.access_logger.handlers.clear()
self.temp_dir.cleanup()
@@ -324,5 +326,53 @@ class TestNotebookMcp(unittest.IsolatedAsyncioTestCase):
self.assertIn("502", str(ctx.exception))
def test_journal_resiste_renommage_suppression_remplacement(self):
"""Vérifie que le journal résiste au renommage, suppression et remplacement (nouvel inode)."""
# Écriture initiale
server.log_access("test-pilote", "notebook_list", None, "ok", 10)
self.assertTrue(os.path.exists(self.access_log_path))
with open(self.access_log_path, "r", encoding="utf-8") as f:
content1 = f.read()
self.assertIn("identity=test-pilote", content1)
self.assertIn("tool=notebook_list", content1)
# 1. Renommage : le fichier d'origine est déplacé
moved = self.access_log_path + ".verif_renomme"
os.rename(self.access_log_path, moved)
self.assertFalse(os.path.exists(self.access_log_path))
# Écriture suivante -> nouveau fichier créé avec la nouvelle ligne
server.log_access("test-pilote", "notebook_get", "notebook:1", "ok", 15)
self.assertTrue(os.path.exists(self.access_log_path))
with open(self.access_log_path, "r", encoding="utf-8") as f:
content2 = f.read()
self.assertIn("tool=notebook_get", content2)
self.assertNotIn("tool=notebook_list", content2)
# 2. Suppression : le fichier est supprimé
os.remove(self.access_log_path)
self.assertFalse(os.path.exists(self.access_log_path))
# Écriture suivante -> nouveau fichier créé avec la nouvelle ligne
server.log_access("test-pilote", "notebook_ask", "notebook:1", "ok", 20)
self.assertTrue(os.path.exists(self.access_log_path))
with open(self.access_log_path, "r", encoding="utf-8") as f:
content3 = f.read()
self.assertIn("tool=notebook_ask", content3)
# 3. Remplacement : remplacement par un fichier avec un autre inode (os.replace)
replaced = self.access_log_path + ".verif_replace"
with open(replaced, "w", encoding="utf-8") as f:
f.write("2026-10-12T00:00:00Z | identity=autre | ligne_externe\n")
os.replace(replaced, self.access_log_path)
# Écriture suivante -> détection du changement d'inode et réouverture
server.log_access("test-pilote", "source_list", "notebook:1", "ok", 5)
with open(self.access_log_path, "r", encoding="utf-8") as f:
content4 = f.read()
self.assertIn("ligne_externe", content4)
self.assertIn("tool=source_list", content4)
if __name__ == "__main__":
unittest.main()